feat: add tracking_codes as param for all on TrackerService#354
Merged
Justintime50 merged 1 commit intomasterfrom Oct 25, 2024
Merged
feat: add tracking_codes as param for all on TrackerService#354Justintime50 merged 1 commit intomasterfrom
Justintime50 merged 1 commit intomasterfrom
Conversation
jchen293
reviewed
Oct 24, 2024
Contributor
jchen293
left a comment
jchen293
left a comment
There was a problem hiding this comment.
Can we have a unit test for this
Member
Author
I don't feel one is warranted. I've hit the API directly with this param and it works as intended. This parameter isn't specific to this library and the function is already tested. Adding another param to an already working function is effectively a no-op. |
jchen293
approved these changes
Oct 24, 2024
nwithan8
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tracking_codesis the preferred param to use for filtering tracking codes on the index endpoint - added hereTesting
Pull Request Type
Please select the option(s) that are relevant to this PR.